Fix for reverse animation with negative speed #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuangq
commented
Jun 19, 2023
| if (speed < 0) | ||
| startTime = Math.min(timestamp - totalDuration / speed, startTime) |
There was a problem hiding this comment.
This bit is doing the same thing as the line above, to calibrate the startTime because timestamp can come in lower, but from the reverse direction.
mattgperry
reviewed
Jun 19, 2023
mattgperry
approved these changes
Jun 19, 2023
shuangq
force-pushed
the
fix/reverse-animation
branch
from
aa4cd38
to
6937a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where setting
animation.time = animation.duration; animation.speed = -1finishes the animation, instead of playing it back reversely. A normal animation is considered done when the current time reaches the animation duration. But for reverse animation with negative speed it's the other way around, it's done when the current time reaches 0.fixes: #2079